[
https://issues.apache.org/jira/browse/HADOOP-4491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739393#action_12739393
]
Hemanth Yamijala commented on HADOOP-4491:
------------------------------------------
Some comments on the task-controller code:
- Code in run_task_as_user can reuse code from initialize_task
- I think test-task-controller can be moved to a test folder following
convention from other C++ modules.
- The log file for the taskcontroller in open_log_file should be closed if we
can't change permissions to it.
- When there's an error in initializing job for any of the m/r local dirs, we
should free the job_dir parameter, right ? Similarly in initializing task.
- Task log dir for cleanup tasks will not have the name
task-attempt-id.cleanup. This seems fine right now. Because we check if the
directory exists and return if it doesn't. Can we comment this ?
- Variable jars_dir not being used in run_task_as_user.
- job_dir needs to be freed before execlp
> Per-job local data on the TaskTracker node should have right access-control
> ---------------------------------------------------------------------------
>
> Key: HADOOP-4491
> URL: https://issues.apache.org/jira/browse/HADOOP-4491
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: security
> Reporter: Arun C Murthy
> Assignee: Vinod K V
> Attachments: HADOOP-4491-20090623-common.1.txt,
> HADOOP-4491-20090623-mapred.1.txt, HADOOP-4491-20090703-common.1.txt,
> HADOOP-4491-20090703-common.txt, HADOOP-4491-20090703.1.txt,
> HADOOP-4491-20090703.txt, HADOOP-4491-20090707-common.txt,
> HADOOP-4491-20090707.txt, HADOOP-4491-20090716-mapred.txt,
> HADOOP-4491-20090803.1.txt, HADOOP-4491-20090803.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
