[
https://issues.apache.org/jira/browse/HADOOP-4491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12741052#action_12741052
]
Hemanth Yamijala commented on HADOOP-4491:
------------------------------------------
Getting close. A few minor points:
- Unrelated to this patch, in Child, we are adding the task's configuration
file as a resource to the defaultConf of the Child. This is used only to get
the proxy, one time when the Child starts (before the config file is added).
So, it appears the adding of config file to the defaultConf variable can be
removed.
- The latest patch is not initializing the task attempt directories on all
disks. This would mean the task may need to create them at runtime under the
job directory. We wanted to the job directory to not have writable permissions
for the user. Would this not be a problem ?
- In the C code, the constant used for R and X for users is S_IREAD and
S_IEXEC. These seem to be obsoleted in favor of S_IRUSR and S_IXUSR. Can we use
those instead ?
- hadoop.log.dir in task-controller.cfg is not needed ?
- The test case for testing the permissions of the localized files and
directories is very good. Thanks !
- secure_path, change_owner and change_mode can be marked static in
task-controller.c as these are somewhat core to the security work in the patch,
and therefore need not be exposed.
I also looked at the Forrest documentation and the javadocs:
- NIT: Typo in TaskTracker.initializeJobDirs() javadoc - 'alter' should be
'later'
- NIT: In javadocs, wherever we say 'download from DFS' should probably be
'download from FS', as it could be local also.
- C documentation - needs update for initialize_job, prepare_task_logs
> Per-job local data on the TaskTracker node should have right access-control
> ---------------------------------------------------------------------------
>
> Key: HADOOP-4491
> URL: https://issues.apache.org/jira/browse/HADOOP-4491
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: security
> Reporter: Arun C Murthy
> Assignee: Vinod K V
> Attachments: HADOOP-4491-20090623-common.1.txt,
> HADOOP-4491-20090623-mapred.1.txt, HADOOP-4491-20090703-common.1.txt,
> HADOOP-4491-20090703-common.txt, HADOOP-4491-20090703.1.txt,
> HADOOP-4491-20090703.txt, HADOOP-4491-20090707-common.txt,
> HADOOP-4491-20090707.txt, HADOOP-4491-20090716-mapred.txt,
> HADOOP-4491-20090803.1.txt, HADOOP-4491-20090803.txt,
> HADOOP-4491-20090806.txt, HADOOP-4491-20090807.2.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
