[ 
https://issues.apache.org/jira/browse/HADOOP-6460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12793708#action_12793708
 ] 

Hairong Kuang commented on HADOOP-6460:
---------------------------------------

I do not have preference on weather creating a new ByteArrayOutputStream or 
having a Shrinkable stream. A shrinkable stream seems to be a more modular way.

>     if (response.size() > MAX_RESP_BUF_SIZE) {
>      LOG.warn("Large respone size " + response.size() + " for call " + call);
>    }
Response.size() counts the valid bytes in the stream. However, 
ShrinkableByteArrayOutputStream#reset() uses the capacity of the array.  Should 
the first response.size() above be response.capacity()?

> Namenode runs of out of memory due to memory leak in ipc Server
> ---------------------------------------------------------------
>
>                 Key: HADOOP-6460
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6460
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.20.1, 0.21.0, 0.22.0
>            Reporter: Suresh Srinivas
>            Assignee: Suresh Srinivas
>            Priority: Blocker
>             Fix For: 0.20.2, 0.21.0, 0.22.0
>
>         Attachments: hadoop-6460.1.patch, hadoop-6460.patch
>
>
> Namenode heap usage grows disproportional to the number objects supports 
> (files, directories and blocks). Based on heap dump analysis, this is due to 
> large growth in ByteArrayOutputStream allocated in 
> o.a.h.ipc.Server.Handler.run().

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to