[
https://issues.apache.org/jira/browse/HADOOP-12356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15061185#comment-15061185
]
Chris Nauroth commented on HADOOP-12356:
----------------------------------------
Hello [~yunqi] and [~elgoiri]. The change in {{SysInfoWindows}} looks good to
me, but it's not clear to me why it was necessary to change
{{NodeResourceMonitorImpl}}. The existing code there calls into
{{SysInfo#getCpuUsage}}, so I expect the change in
{{SysInfoWindows#getCpuUsage}} is sufficient. In fact, it seems like the
{{NodeResourceMonitorImpl}} change would break Linux, which was already
accounting for number of processors in {{SysInfoLinux#getCpuUsage}}.
> CPU usage statistics on Windows
> -------------------------------
>
> Key: HADOOP-12356
> URL: https://issues.apache.org/jira/browse/HADOOP-12356
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Environment: CPU: Intel Xeon
> OS: Windows server
> Reporter: Yunqi Zhang
> Assignee: Yunqi Zhang
> Labels: easyfix, newbie, patch
> Attachments: 0001-Correct-the-CPU-usage-calcualtion.patch,
> 0001-Correct-the-CPU-usage-calcualtion.patch, HADOOP-12356-v3.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> The CPU usage information on Windows is computed incorrectly. The proposed
> patch fixes the issue, and unifies the the interface with Linux.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
