[
https://issues.apache.org/jira/browse/HADOOP-12356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15062681#comment-15062681
]
Chris Nauroth commented on HADOOP-12356:
----------------------------------------
I'm not confident enough about the YARN part of this patch, so I'd like to call
in help from someone deeper on YARN. [~leftnoteasy], would you mind taking a
look? I'm +1 for the change in {{SysInfoWindows}}, but I'm not sure about the
change in {{NodeResourceMonitorImpl}}.
[~elgoiri], my understanding of the resource monitoring code at this layer is
that it needs to track utilization as a percentage, not in units of vcores.
I'd also be concerned that changing this calculation could cause unusual
effects during a rolling upgrade scenario, when some NodeManagers are running
the old calculation and some NodeManagers are running the new calculation. I
expect Wangda can give us a more definitive answer.
Thanks!
> CPU usage statistics on Windows
> -------------------------------
>
> Key: HADOOP-12356
> URL: https://issues.apache.org/jira/browse/HADOOP-12356
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Environment: CPU: Intel Xeon
> OS: Windows server
> Reporter: Yunqi Zhang
> Assignee: Yunqi Zhang
> Labels: easyfix, newbie, patch
> Attachments: 0001-Correct-the-CPU-usage-calcualtion.patch,
> 0001-Correct-the-CPU-usage-calcualtion.patch, HADOOP-12356-v3.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> The CPU usage information on Windows is computed incorrectly. The proposed
> patch fixes the issue, and unifies the the interface with Linux.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)