[
https://issues.apache.org/jira/browse/HADOOP-12892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15236793#comment-15236793
]
Allen Wittenauer commented on HADOOP-12892:
-------------------------------------------
Thanks for the review. Clearly some bugs. But some clarification/comments:
bq. Shall we change "patchprocess" to "releaseprocess" or some such for LOGDIR?
patchprocess is in .gitignore and who knows where else and I didn't want to add
another one to reduce the amount of pollution.
bq. \-\-asfrelease sets NATIVE and SIGN, so the "\-\-asfrelease requires
\-\-sign" validation will never trigger
Actually, it can:
{code}
if [[ ! -d "${HOME}/.gnupg" ]]; then
hadoop_error "ERROR: No .gnupg dir. Disabling signing capability."
SIGN=false
fi
...
if [[ "${ASFRELEASE}" = true ]]; then
if [[ "${SIGN}" = false ]]; then
hadoop_error "ERROR: --asfrelease requires --sign. Exiting."
exit
fi
{code}
In other words, if there is no .gnupg directory, then override the user's
request for signing support as a warning. But if an ASF release is requested,
fail out.
bq. Should we even support building on Darwin? I'd rather it just abort for
unsupported platforms. Is windows supported for that matter?
There's no reason why someone can't use create-release to build non-Apache
releases...
bq. Related to previous, it'd be nice to be able to do \-\-sign independent of
the build.
IMO, but that's an outside of the Apache process and outside of create-release
problem. I don't think I'd trust an RM that can't write a simple shell for
loop. One of my goals here is to lock in stone the ASF release process since
it's pretty clear that people screw it up all the time and/or do very bad
things (like build them on Jenkins).
> fix/rewrite create-release
> --------------------------
>
> Key: HADOOP-12892
> URL: https://issues.apache.org/jira/browse/HADOOP-12892
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Reporter: Allen Wittenauer
> Assignee: Allen Wittenauer
> Priority: Blocker
> Attachments: HADOOP-12892.00.patch, HADOOP-12892.01.patch
>
>
> create-release needs some major surgery.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
