[
https://issues.apache.org/jira/browse/HADOOP-13112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15275264#comment-15275264
]
Larry McCay commented on HADOOP-13112:
--------------------------------------
Nice, [~mattpaduano].
FYI - KeyShell is based on exactly the same pattern and should also be
refactored as a subclass of CommandShell.
Also, HADOOP-12942 is something that you should be aware of. It should be ready
to commit early next week and these two patches may clash a little. I do think
that the changes will be isolated to the provider frameworks and the individual
commands but it is something to be aware of.
> Change CredentialShell to use CommandShell base class
> -----------------------------------------------------
>
> Key: HADOOP-13112
> URL: https://issues.apache.org/jira/browse/HADOOP-13112
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Matthew Paduano
> Assignee: Matthew Paduano
> Priority: Minor
> Attachments: HADOOP-13112.01.patch
>
>
> org.apache.hadoop.tools.CommandShell is a base class created for use by
> DtUtilShell. It was inspired by CredentialShell and much of it was taken
> verbatim. It should be a simple change to get CredentialShell to use the
> base class and simplify its code without changing its functionality.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
