[ https://issues.apache.org/jira/browse/HADOOP-13112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15291644#comment-15291644 ]
Allen Wittenauer commented on HADOOP-13112: ------------------------------------------- I'm not seeing anything obviously wrong here, but the patch does need to be rebased. > Change CredentialShell to use CommandShell base class > ----------------------------------------------------- > > Key: HADOOP-13112 > URL: https://issues.apache.org/jira/browse/HADOOP-13112 > Project: Hadoop Common > Issue Type: Improvement > Reporter: Matthew Paduano > Assignee: Matthew Paduano > Priority: Minor > Attachments: HADOOP-13112.01.patch, HADOOP-13112.02.patch, > HADOOP-13112.03.patch, HADOOP-13112.04.patch > > > org.apache.hadoop.tools.CommandShell is a base class created for use by > DtUtilShell. It was inspired by CredentialShell and much of it was taken > verbatim. It should be a simple change to get CredentialShell to use the > base class and simplify its code without changing its functionality. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org