[
https://issues.apache.org/jira/browse/HADOOP-13112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15277211#comment-15277211
]
Matthew Paduano commented on HADOOP-13112:
------------------------------------------
do you agree that the only conflicts with the current merge
are in run() and printCredShellUsage/printShellUsage?
I might suggest you do what dtutil did. it has a command, "help".
there is not an object for it. help is dispatched straight from init().
it does the same thing as a parse error. it dumps the usage strings
from all the subcommand objects (implemented via an abstract method).
don't change run(). don't use the printUsage method to signal run().
what do you think? will that work? I can implement the code if you
want to commit first and let me handle the merge. that's the approach
I would take, unless you suggest something different.
> Change CredentialShell to use CommandShell base class
> -----------------------------------------------------
>
> Key: HADOOP-13112
> URL: https://issues.apache.org/jira/browse/HADOOP-13112
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Matthew Paduano
> Assignee: Matthew Paduano
> Priority: Minor
> Attachments: HADOOP-13112.01.patch, HADOOP-13112.02.patch
>
>
> org.apache.hadoop.tools.CommandShell is a base class created for use by
> DtUtilShell. It was inspired by CredentialShell and much of it was taken
> verbatim. It should be a simple change to get CredentialShell to use the
> base class and simplify its code without changing its functionality.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
