[ 
https://issues.apache.org/jira/browse/HADOOP-12893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15284066#comment-15284066
 ] 

Andrew Wang commented on HADOOP-12893:
--------------------------------------

Thanks [~busbey]. I sent out a mail to common-dev, we'll see about what comes 
back. Do you have references for these statements? I believe you, but I would 
like a comprehensive guide for what's required. Else we're liable to still get 
it wrong.

In the meanwhile, some review comments based on the Apache page on this: 
http://www.apache.org/dev/licensing-howto.html

* [No need to list ALv2 
dependencies](http://www.apache.org/dev/licensing-howto.html#alv2-dep) in 
LICENSE
* We're missing version numbers. [Licenses can change in later 
releases.](http://www.apache.org/dev/licensing-howto.html#permissive-deps)
* IIUC we [don't need to list the copyrights for BSD and MIT licensed deps in 
NOTICE](http://www.apache.org/dev/licensing-howto.html#mod-notice). I'm not 
100% sure how this applies to included JARs, but the understanding for source 
files is that you just leave their copyright headers and it's okay. Included 
JARs should also have their LICENSE/NOTICE in their own META-INF dirs, which 
would also satisfy the copyright requirement.
* I'd also be in favor of checking the source data and scripts into the repo, 
to make this easier in the future. Ideally all these files are auto-generated.

> Verify LICENSE.txt and NOTICE.txt
> ---------------------------------
>
>                 Key: HADOOP-12893
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12893
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 2.8.0, 2.7.3, 2.6.5, 3.0.0-alpha1
>            Reporter: Allen Wittenauer
>            Assignee: Xiao Chen
>            Priority: Blocker
>         Attachments: HADOOP-12893.01.patch
>
>
> We have many bundled dependencies in both the source and the binary artifacts 
> that are not in LICENSE.txt and NOTICE.txt.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to