[ 
https://issues.apache.org/jira/browse/HADOOP-13354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394497#comment-15394497
 ] 

Chris Nauroth commented on HADOOP-13354:
----------------------------------------

[[email protected]], thank you for the patch.

I'm unclear about why the block ID generation logic in 
{{BlockBlobAppendStream}} needed to change.  I remember this code was 
originally implemented to match block ID logic inside the Azure Storage SDK.  
Is this updating our code to keep in sync with the logic of 4.2.0, or is there 
some other reason for this part of the change?

{code}
    if (this.blockIdPrefix == null) {
      throw new IOException("Append Stream in invalid state. blockIdPrefix not 
set correctly");
    }
{code}

It appears this check is unnecessary.  The constructor always calls 
{{setBlocksCountAndBlockIdPrefix}}, which always guarantees that 
{{blockIdPrefix}} has been initialized to a non-null value.


> Update WASB driver to use the latest version (4.2.0) of SDK for Microsoft 
> Azure Storage Clients
> -----------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-13354
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13354
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs/azure
>            Reporter: Sivaguru Sankaridurg
>         Attachments: HADOOP-13354.001.patch, HADOOP-13354.002.patch, 
> HADOOP-13354.003.patch, HADOOP-13354.004.patch, Test-Results-With-4.2.0-fixes
>
>
> Update WASB driver to use the latest version (4.2.0) of SDK for Microsoft 
> Azure Storage Clients.
> We are currently using version 2.2.0 of the SDK.
> Version 4.2.0 brings some breaking changes. 
> Need to fix code to resolve all these breaking changes and certify that 
> everything works properly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to