[
https://issues.apache.org/jira/browse/HADOOP-13446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15430777#comment-15430777
]
Chris Nauroth commented on HADOOP-13446:
----------------------------------------
Patch 006 for trunk got a full +1 from pre-commit.
Patch 006 for branch-2 had warnings on whitespace and Checkstyle. I can fix
whitespace on commit. I do not plan to fix the remaining Checkstyle warnings.
They are "no package-info.java" warnings on test code, which aren't
particularly valuable. The patch already provides a large overall net
reduction in Checkstyle warnings from my clean-up work.
Steve, would you please take another look and let me know if you are still +1?
That's a good point about the HowToContribute wiki page. I'll update that
after this gets committed.
> Support running isolated unit tests separate from AWS integration tests.
> ------------------------------------------------------------------------
>
> Key: HADOOP-13446
> URL: https://issues.apache.org/jira/browse/HADOOP-13446
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Reporter: Chris Nauroth
> Assignee: Chris Nauroth
> Attachments: HADOOP-13446-HADOOP-13345.001.patch,
> HADOOP-13446-HADOOP-13345.002.patch, HADOOP-13446-HADOOP-13345.003.patch,
> HADOOP-13446-branch-2.006.patch, HADOOP-13446.004.patch,
> HADOOP-13446.005.patch, HADOOP-13446.006.patch
>
>
> Currently, the hadoop-aws module only runs Surefire if AWS credentials have
> been configured. This implies that all tests must run integrated with the
> AWS back-end. It also means that no tests run as part of ASF pre-commit.
> This issue proposes for the hadoop-aws module to support running isolated
> unit tests without integrating with AWS. This will benefit S3Guard, because
> we expect the need for isolated mock-based testing to simulate eventual
> consistency behavior. It also benefits hadoop-aws in general by allowing
> pre-commit to do something more valuable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
