[
https://issues.apache.org/jira/browse/HADOOP-13446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15431335#comment-15431335
]
Aaron Fabbri commented on HADOOP-13446:
---------------------------------------
Reviewing latest branch-2 patch. Compared to the 002 patch I reviewed earlier:
- Moves S3 Contract tests to be integration tests.
- Improves some comments
- Adds some tests for credentials provider (invalid class)
- Fixes some code style issues
- Some enhancements for ITestS3ADirectoryPerf
- Cleanup FileContext after yarn/TestS3A.java
I'm +1 on the branch-2 patch. Will review trunk diff next.
> Support running isolated unit tests separate from AWS integration tests.
> ------------------------------------------------------------------------
>
> Key: HADOOP-13446
> URL: https://issues.apache.org/jira/browse/HADOOP-13446
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Reporter: Chris Nauroth
> Assignee: Chris Nauroth
> Attachments: HADOOP-13446-HADOOP-13345.001.patch,
> HADOOP-13446-HADOOP-13345.002.patch, HADOOP-13446-HADOOP-13345.003.patch,
> HADOOP-13446-branch-2.006.patch, HADOOP-13446.004.patch,
> HADOOP-13446.005.patch, HADOOP-13446.006.patch
>
>
> Currently, the hadoop-aws module only runs Surefire if AWS credentials have
> been configured. This implies that all tests must run integrated with the
> AWS back-end. It also means that no tests run as part of ASF pre-commit.
> This issue proposes for the hadoop-aws module to support running isolated
> unit tests without integrating with AWS. This will benefit S3Guard, because
> we expect the need for isolated mock-based testing to simulate eventual
> consistency behavior. It also benefits hadoop-aws in general by allowing
> pre-commit to do something more valuable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
