[ 
https://issues.apache.org/jira/browse/HADOOP-13522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15521807#comment-15521807
 ] 

Akira Ajisaka commented on HADOOP-13522:
----------------------------------------

Mostly looks good to me.
* Would you add test case?
* Would you update the document? 
(hadoop-common-project/hadoop-common/src/site/markdown/FileSystemShell.md)

> Permissions on fs stat added
> ----------------------------
>
>                 Key: HADOOP-13522
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13522
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs
>    Affects Versions: 3.0.0-alpha1
>            Reporter: Alex Garbarini
>            Priority: Minor
>             Fix For: 3.0.0-alpha1
>
>         Attachments: HADOOP-13522.001.patch, HADOOP-13522.002.patch, 
> HADOOP-13522.003.patch
>
>
> This patch adds to fs/shell/Stat.java the missing options of %a and %A. 
> FileStatus already contains the getPermission() method required for returning 
> symbolic permissions. FsPermission contains the method to return the binary 
> short, but nothing to present in standard Octal format. 
> Most UNIX admins base their work on such standard octal permissions. Hence, 
> this patch also introduces one tiny method to translate the toShort() return 
> into octal.
> Build has already passed unit tests and javadoc.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to