[
https://issues.apache.org/jira/browse/HADOOP-13522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15548035#comment-15548035
]
Akira Ajisaka commented on HADOOP-13522:
----------------------------------------
Thank you for updating the patch, [~algarbar].
1. Would you render the lines within 80 characters?
{code:title=FsPermission.java}
int octal = (n >>> 9 & 1)*1000 + (n >>> 6 & 7)*100 + (n >>> 3 & 7)*10 + (n
& 7);
{code}
{code:title=TestDFSShell.java}
assertTrue(out.toString(),
out.toString().contains(status1.getPermission().toString()));
{code}
2. Would you add an assertion for {{%a}} option?
{code}
assertTrue(out.toString(), out.toString().contains(
Short.toString(status1.getPermission().toShort())));
{code}
3. Would you add assertions for testFile2 as well?
(You don't need to set the assignee to me. In this project, assignee is a
developer who creates a patch.)
> Permissions on fs stat added
> ----------------------------
>
> Key: HADOOP-13522
> URL: https://issues.apache.org/jira/browse/HADOOP-13522
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Affects Versions: 3.0.0-alpha1
> Reporter: Alex Garbarini
> Assignee: Akira Ajisaka
> Attachments: HADOOP-13522.001.patch, HADOOP-13522.002.patch,
> HADOOP-13522.003.patch, HADOOP-13522.004.patch, HADOOP-13522.005.patch,
> HADOOP-13522.006.patch
>
>
> This patch adds to fs/shell/Stat.java the missing options of %a and %A.
> FileStatus already contains the getPermission() method required for returning
> symbolic permissions. FsPermission contains the method to return the binary
> short, but nothing to present in standard Octal format.
> Most UNIX admins base their work on such standard octal permissions. Hence,
> this patch also introduces one tiny method to translate the toShort() return
> into octal.
> Build has already passed unit tests and javadoc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
