[ 
https://issues.apache.org/jira/browse/HADOOP-13522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15522270#comment-15522270
 ] 

Akira Ajisaka commented on HADOOP-13522:
----------------------------------------

Thank you for updating the patch!

bq. Would you be willing to submit any new, required case?
I want you to submit some test cases, but if you don't want to work for 
creating tests or don't have time to do this, I'm willing to take it over.

I searched existing test cases but unfortunately there is no test case for fs 
-stat command. Therefore I'm thinking we need to create a new test class in 
{{hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell}}.
 In the class, we execute all the options of fs -stat command and verify the 
output. We can re-use the other test classes in the directory as reference. Let 
me know if you need any help.

> Permissions on fs stat added
> ----------------------------
>
>                 Key: HADOOP-13522
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13522
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs
>    Affects Versions: 3.0.0-alpha1
>            Reporter: Alex Garbarini
>            Priority: Minor
>         Attachments: HADOOP-13522.001.patch, HADOOP-13522.002.patch, 
> HADOOP-13522.003.patch, HADOOP-13522.004.patch
>
>
> This patch adds to fs/shell/Stat.java the missing options of %a and %A. 
> FileStatus already contains the getPermission() method required for returning 
> symbolic permissions. FsPermission contains the method to return the binary 
> short, but nothing to present in standard Octal format. 
> Most UNIX admins base their work on such standard octal permissions. Hence, 
> this patch also introduces one tiny method to translate the toShort() return 
> into octal.
> Build has already passed unit tests and javadoc.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to