Xiao Chen commented on HADOOP-13702:

Thanks [~jingcheng...@intel.com] for revving.
The separate readlock / writelock looks good.

I feel the various code duplication should still be improved. IMHO we could 
just have an instrumentation class - what type of lock it's instrumenting 
should be separated.

Also, if I read [~chris.douglas]'s comment correctly:
bq. The HDFS InstrumentedLock class contains nearly identical functionality. If 
Common will introduce other instrumented locks, then this should replace what's 
in HDFS.
The proposal was, if we put this in common, we should replace the existing 
{{InstrumentedLock}} in hdfs, instead of copy-pasting. So we don't have to 
'align' with that class in HDFS. :)

Would also like to hear what others think.

> Add a new instrumented read-write lock
> --------------------------------------
>                 Key: HADOOP-13702
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13702
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: common
>            Reporter: Jingcheng Du
>            Assignee: Jingcheng Du
>         Attachments: HADOOP-13702-V6.patch, HDFS-10924-2.patch, 
> HDFS-10924-3.patch, HDFS-10924-4.patch, HDFS-10924-5.patch, HDFS-10924.patch
> Add a new instrumented read-write lock in hadoop common, so that the 
> HDFS-9668 can use this to improve the locking in FsDatasetImpl

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to