[
https://issues.apache.org/jira/browse/HADOOP-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15593132#comment-15593132
]
Chris Douglas commented on HADOOP-13702:
----------------------------------------
Thank you for all the refinements, [~jingcheng...@intel.com]. This is looking
good.
* The constructors accepting {{Timer}} can be package-private and annotated as
{{\@VisibleForTesting}}.
* {{InstrumentedReadWriteLock}} could accept an instance of {{ReadWriteLock}}
instead of creating one. Similarly, the read/write locks could accept a
{{ReadWriteLock}} in their constructor. IRWL could also have the convenience
constructor, as written.
* {{InstrumentedReadWriteLock}} fields can be final
* Shouldn't the {{ThreadLocal<Long> readLockHeldTimeStamp}} field be final, not
transient?
* Is {{InstrumentedLock}} unused in HDFS? I expected to see package changes in
the HDFS project for the imports to resolve.
> Add a new instrumented read-write lock
> --------------------------------------
>
> Key: HADOOP-13702
> URL: https://issues.apache.org/jira/browse/HADOOP-13702
> Project: Hadoop Common
> Issue Type: Improvement
> Components: common
> Reporter: Jingcheng Du
> Assignee: Jingcheng Du
> Attachments: HADOOP-13702-V6.patch, HADOOP-13702-V7.patch,
> HADOOP-13702-V8.patch, HDFS-10924-2.patch, HDFS-10924-3.patch,
> HDFS-10924-4.patch, HDFS-10924-5.patch, HDFS-10924.patch
>
>
> Add a new instrumented read-write lock in hadoop common, so that the
> HDFS-9668 can use this to improve the locking in FsDatasetImpl
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
