[
https://issues.apache.org/jira/browse/HADOOP-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15593061#comment-15593061
]
Xiao Chen commented on HADOOP-13702:
------------------------------------
Thanks for the new patch [[email protected]]! Looks pretty nice, I think
we're close.
Some more comments:
- We could modify {{InstrumentedReadLock#tryLock}} to do it in the OO way. That
is, make {{recordLockAcquireTimestamp}} a base-class method, and override it in
the readlock. This way we don't have to override the {{tryLock}} which mostly
duplicates the base class logic.
- Similar to {{unlock}} and {{check}}
- Suggest to put more details in javadoc of the 3 new classes, and reference to
{{InstrumentedLock}}. Maybe something like
{code}
This is a wrap class of a {@link InstrumentedLock} and a WriteLock.
{code}
Otherwise LGTM.
> Add a new instrumented read-write lock
> --------------------------------------
>
> Key: HADOOP-13702
> URL: https://issues.apache.org/jira/browse/HADOOP-13702
> Project: Hadoop Common
> Issue Type: Improvement
> Components: common
> Reporter: Jingcheng Du
> Assignee: Jingcheng Du
> Attachments: HADOOP-13702-V6.patch, HADOOP-13702-V7.patch,
> HADOOP-13702-V8.patch, HDFS-10924-2.patch, HDFS-10924-3.patch,
> HDFS-10924-4.patch, HDFS-10924-5.patch, HDFS-10924.patch
>
>
> Add a new instrumented read-write lock in hadoop common, so that the
> HDFS-9668 can use this to improve the locking in FsDatasetImpl
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
