[
https://issues.apache.org/jira/browse/HADOOP-13929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15788235#comment-15788235
]
Chris Nauroth commented on HADOOP-13929:
----------------------------------------
Hello [~jzhuge]. Thank you for the patch.
I would prefer to see this match the layout we've established in places like
hadoop-azure and hadoop-aws. We could keep the contract-test-options.xml file
as a placeholder, which then uses XInclude to include a credential file that is
left out of source control by .gitignore. The placeholder file is a spot to
leave commented out samples of how to configure it.
> ADLS should not check in contract-test-options.xml
> --------------------------------------------------
>
> Key: HADOOP-13929
> URL: https://issues.apache.org/jira/browse/HADOOP-13929
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs/adl, test
> Affects Versions: 3.0.0-alpha2
> Reporter: John Zhuge
> Assignee: John Zhuge
> Fix For: 3.0.0-alpha2
>
> Attachments: HADOOP-13929.001.patch, HADOOP-13929.002.patch
>
>
> Should not check in the file {{contract-test-options.xml}}. Make sure the
> file is excluded by {{.gitignore}}. Make sure ADLS {{index.md}} provides a
> complete example of this file.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
