[ 
https://issues.apache.org/jira/browse/HADOOP-13780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15795593#comment-15795593
 ] 

Andrew Wang commented on HADOOP-13780:
--------------------------------------

Thanks for your hard work on this Xiao! +1 LGTM to unblock the release, though 
we need a follow-on to improve the scripts. I'm sure these are already on your 
todo list, but a few thoughts along those lines:

* We should try to remove the dependency on the externally managed GDoc. 
Checking in an exported sqlite DB or some csvs would be an improvement.
* generate.py is still in the spreadsheet
* the manual merge step is unfortunate, ideally everything is fully-generated 
by a single script and input data.

Also, did we ever file a JIRA to do a precommit check?

> LICENSE/NOTICE are out of date for source artifacts
> ---------------------------------------------------
>
>                 Key: HADOOP-13780
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13780
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: common
>    Affects Versions: 3.0.0-alpha2
>            Reporter: Sean Busbey
>            Assignee: Xiao Chen
>            Priority: Blocker
>         Attachments: HADOOP-13780.01.patch, HADOOP-13780.02.patch, 
> HADOOP-13780.03-with-scripts.patch, HADOOP-13780.03.patch
>
>
> we need to perform a check that all of our bundled works are properly 
> accounted for in our LICENSE/NOTICE files.
> At a minimum, it looks like HADOOP-10075 introduced some changes that have 
> not been accounted for.
> e.g. the jsTree plugin found at 
> {{hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/static/jt/jquery.jstree.js}}
>  does not show up in LICENSE.txt to (a) indicate that we're redistributing it 
> under the MIT option and (b) give proper citation of the original copyright 
> holder per ASF policy.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to