[
https://issues.apache.org/jira/browse/HADOOP-13780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15800472#comment-15800472
]
Xiao Chen commented on HADOOP-13780:
------------------------------------
Thanks a lot for the review [~busbey]!
bq. The jQuery entries look to cover things other than the bundling that's in
the HBase Server 1.1.3 jar. Also the jQuery Foundation copyright entry is
missing any year(s). The bit bundled in the HBase jar is version 1.8.3 with (c)
2012.
jquery actually has been like this long ago... Looking at
http://www.apache.org/dev/licensing-howto.html#permissive-deps , is the year
required? I'm guessing the current way is written without year because the
first 2 are 2005, 2013 and the last is 2012:
{quote}
...
hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/jquery-1.10.2.min.js
hadoop-tools/hadoop-sls/src/main/html/js/thirdparty/jquery.js
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/static/jquery
--------------------------------------------------------------------------------
Copyright jQuery Foundation and other contributors, https://jquery.org/
...
{quote}
I'll be happy to update accordingly, but wanted to make sure - apache licensing
seems is saying 'add a pointer', 'short note summarizing', and the example
there didn't even mention copyright...
bq. There's no entry for the bundled Orca Logo from the HBase Server jar. It's
mentioned in NOTICE, but LICENSE should have a complete reference for the CC-BY
3.0 license (found in LICENSE from the hbase-server-1.1.3.jar)
Copied from there and added to hadoop LICENSE.
bq. I don't see any actual inclusion of HBase Shell 1.1.3, HBase IT Tests
1.1.3, or HBase Testing Utility 1.1.3 artifacts. I'm not sure if this is an
oversight in the constructed NOTICE or in the bin distribution tarball.
Good catch, that inspired me to look into the {{mvn
license:aggregate-add-third-party -X -e}} output from step1. I think we can run
with {{-Dlicense.excludedScopes=test}} when generating.
Attached patch 4 is based on the new run excluding {{test}} scope. Was able to
take out a few test-only, not-bundled deps from patch 3.
> LICENSE/NOTICE are out of date for source artifacts
> ---------------------------------------------------
>
> Key: HADOOP-13780
> URL: https://issues.apache.org/jira/browse/HADOOP-13780
> Project: Hadoop Common
> Issue Type: Bug
> Components: common
> Affects Versions: 3.0.0-alpha2
> Reporter: Sean Busbey
> Assignee: Xiao Chen
> Priority: Blocker
> Attachments: HADOOP-13780.01.patch, HADOOP-13780.02.patch,
> HADOOP-13780.03-with-scripts.patch, HADOOP-13780.03.patch
>
>
> we need to perform a check that all of our bundled works are properly
> accounted for in our LICENSE/NOTICE files.
> At a minimum, it looks like HADOOP-10075 introduced some changes that have
> not been accounted for.
> e.g. the jsTree plugin found at
> {{hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/static/jt/jquery.jstree.js}}
> does not show up in LICENSE.txt to (a) indicate that we're redistributing it
> under the MIT option and (b) give proper citation of the original copyright
> holder per ASF policy.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
