[
https://issues.apache.org/jira/browse/HADOOP-14120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15906823#comment-15906823
]
Yuanbo Liu commented on HADOOP-14120:
-------------------------------------
[[email protected]] Thanks for your review.
Not sure whether I get your point, I assume that you're asking why I didn't
write test case for my patch.
This patch is trying to get rid of {{setOptionalPutRequestParameters}} in
{{S3ABlockOutputStream#putObject}}, because {{setOptionalPutRequestParameters}}
has been used in {{S3AFileSystem#newPutObjectRequest}}, it's a duplicated
method in {{putObject}} and make users confuse.
If "fs.s3a.fast.upload" is true, {{S3ABlockOutputStream}} will be used in
{{S3AFileSystem#create}}, then when the output stream is closed, the test cases
will cover my code change. I've seen a lot of create operation of
{{S3AFileSystem}} in many test cases, I believe there is no need to add test
case for {{S3ABlockOutputStream#putObject}}.
Triggering s3 test cases in local env seems to need some configurations and s3
account, right?
> needless S3AFileSystem.setOptionalPutRequestParameters in
> S3ABlockOutputStream putObject()
> ------------------------------------------------------------------------------------------
>
> Key: HADOOP-14120
> URL: https://issues.apache.org/jira/browse/HADOOP-14120
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 2.9.0
> Reporter: Steve Loughran
> Assignee: Yuanbo Liu
> Priority: Minor
> Attachments: HADOOP-14120.001.patch
>
>
> There's a call to {{S3AFileSystem.setOptionalPutRequestParameters()}} in {{
> S3ABlockOutputStream putObject()}}
> The put request has already been created by the FS; this call is only
> superflous and potentially confusing.
> Proposed: cut it, make the {{setOptionalPutRequestParameters()}} method
> private.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
