[
https://issues.apache.org/jira/browse/HADOOP-14120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15938220#comment-15938220
]
Steve Loughran commented on HADOOP-14120:
-----------------------------------------
+1
Tested: s3 ireland, only the usual intermittent rmdir one:
Results :
{code}
Failed tests:
ITestS3AContractRootDir>AbstractContractRootDirectoryTest.testRmEmptyRootDirNonRecursive:95->Assert.fail:88
After 1 attempts: listing after rm /* not empty
final [00] S3AFileStatus{path=s3a://hwdev-steve-ireland-new/fork-2;
isDirectory=true; modification_time=0; access_time=0; owner=stevel;
group=stevel; permission=rwxrwxrwx; isSymlink=false} isEmptyDirectory=false
{code}
Maybe we should just disable that test
> needless S3AFileSystem.setOptionalPutRequestParameters in
> S3ABlockOutputStream putObject()
> ------------------------------------------------------------------------------------------
>
> Key: HADOOP-14120
> URL: https://issues.apache.org/jira/browse/HADOOP-14120
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 2.9.0
> Reporter: Steve Loughran
> Assignee: Yuanbo Liu
> Priority: Minor
> Attachments: HADOOP-14120.001.patch
>
>
> There's a call to {{S3AFileSystem.setOptionalPutRequestParameters()}} in {{
> S3ABlockOutputStream putObject()}}
> The put request has already been created by the FS; this call is only
> superflous and potentially confusing.
> Proposed: cut it, make the {{setOptionalPutRequestParameters()}} method
> private.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
