[ 
https://issues.apache.org/jira/browse/HADOOP-14120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15938229#comment-15938229
 ] 

Hudson commented on HADOOP-14120:
---------------------------------

FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #11444 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/11444/])
HADOOP-14120 needless S3AFileSystem.setOptionalPutRequestParameters in (stevel: 
rev a5a4867f3b193a137a6260d539da7e21f02ffab3)
* (edit) 
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3ABlockOutputStream.java
* (edit) 
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java


> needless S3AFileSystem.setOptionalPutRequestParameters in 
> S3ABlockOutputStream putObject()
> ------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-14120
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14120
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>    Affects Versions: 2.9.0
>            Reporter: Steve Loughran
>            Assignee: Yuanbo Liu
>            Priority: Minor
>         Attachments: HADOOP-14120.001.patch
>
>
> There's a call to {{S3AFileSystem.setOptionalPutRequestParameters()}} in {{ 
> S3ABlockOutputStream putObject()}}
> The put request has already been created by the FS; this call is only 
> superflous and potentially confusing.
> Proposed: cut it, make the {{setOptionalPutRequestParameters()}} method 
> private.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to