[ 
https://issues.apache.org/jira/browse/HADOOP-13715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15933810#comment-15933810
 ] 

Andrew Wang commented on HADOOP-13715:
--------------------------------------

Hi Manoj, thanks for revving, thanks also to Steve for reviewing, overall looks 
really good, few small comments:

* FileStatus#toString, why do we hide the EC bit behind an if statement? I'm 
also wondering if we should touch this at all for compatibility reasons. We 
didn't modify toString for the ACL bit or encrypted bit. [[email protected]], 
thoughts? I remember there was some discussion of public vs. private toString 
methods. Maybe we handle all these bits in a new JIRA?
* In the new WebHDFS test, it'd be good to assert not just that the statuses 
are equal, but also that the "normal" ones are true or false as appropriate.
* Could we add HTTPFS tests too?

> Add isErasureCoded() API to FileStatus class
> --------------------------------------------
>
>                 Key: HADOOP-13715
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13715
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs
>    Affects Versions: 3.0.0-alpha1
>            Reporter: Wei-Chiu Chuang
>            Assignee: Manoj Govindassamy
>            Priority: Blocker
>              Labels: hdfs-ec-3.0-must-do
>         Attachments: HADOOP-13715.01.patch, HADOOP-13715.02.patch
>
>
> Per the discussion in 
> [HDFS-10971|https://issues.apache.org/jira/browse/HDFS-10971?focusedCommentId=15567108&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15567108]
>  I would like to add a new API {{isErasureCoded()}} to {{FileStatus}} so that 
> tools and downstream applications can tell if it needs to treat a file 
> differently.
> Hadoop tools that can benefit from this effort include: distcp and 
> teragen/terasort.
> Downstream applications such as flume or hbase may also benefit from it.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to