[
https://issues.apache.org/jira/browse/HADOOP-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16001801#comment-16001801
]
Tsuyoshi Ozawa commented on HADOOP-14284:
-----------------------------------------
[~djp] As I mentioned on HADOOP-14386, I'm okay to downgrade version of Guava
to 0.11.2. On the other hand, I'm still thinking that shading itself is very
useful.
{quote}
However, the other approach - to stay at a version with other downstream
projects unless must be changed (and should change with downstream projects
together) - seems the best strategy here. I didn't see any necessary for
upgrading guava and HADOOP-10101 failed to convince me.
{quote}
First of all, the opinions of users on HADOOP-10101 looks to me like positive
against shading Guava. Secondly, as stack mentioned, the quality of Guava
itself is nice. Guava also announces deprecated methods in the future on ahead.
For example.
https://google.github.io/guava/releases/14.0/api/docs/com/google/common/io/LimitInputStream.html
If we shade and relocate Guava inside Hadoop, we can catch up these changes
easily because the dependency doesn't leak to user-level. It's not a problem of
Guava, IIUC - it's a problem that we failed to decouple with user-level library
and server-side library. There is a possibility that the reams of complaint
come from IDE problem. Hence, I will post a next patch with IDE support after
HADOOP-14386.
> Shade Guava everywhere
> ----------------------
>
> Key: HADOOP-14284
> URL: https://issues.apache.org/jira/browse/HADOOP-14284
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 3.0.0-alpha3
> Reporter: Andrew Wang
> Assignee: Tsuyoshi Ozawa
> Priority: Blocker
> Attachments: HADOOP-14238.pre001.patch, HADOOP-14284.002.patch,
> HADOOP-14284.004.patch, HADOOP-14284.007.patch, HADOOP-14284.010.patch,
> HADOOP-14284.012.patch
>
>
> HADOOP-10101 upgraded the guava version for 3.x to 21.
> Guava is broadly used by Java projects that consume our artifacts.
> Unfortunately, these projects also consume our private artifacts like
> {{hadoop-hdfs}}. They also are unlikely on the new shaded client introduced
> by HADOOP-11804, currently only available in 3.0.0-alpha2.
> We should shade Guava everywhere to proactively avoid breaking downstreams.
> This isn't a requirement for all dependency upgrades, but it's necessary for
> known-bad dependencies like Guava.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
