[
https://issues.apache.org/jira/browse/HADOOP-14397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16084953#comment-16084953
]
Aaron Fabbri commented on HADOOP-14397:
---------------------------------------
Code looks good to me. Nice test factorization.
I can't access any of the Yetus artifact links above, not sure what the problem
is. Looks like there was a failure in TestRawlocalContractAppend.
I did build the patch and run ITestS3AContractCreate successfully.
> Pull up the builder pattern to FileSystem and add AbstractContractCreateTest
> for it
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-14397
> URL: https://issues.apache.org/jira/browse/HADOOP-14397
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: common, fs, hdfs-client
> Affects Versions: 2.9.0, 3.0.0-alpha3
> Reporter: Lei (Eddy) Xu
> Assignee: Lei (Eddy) Xu
> Attachments: HADOOP-14397.000.patch
>
>
> After reach the stability of the Builder APIs, we should promote the API from
> {{DistributedFileSystem}} to {{FileSystem}}, and add necessary contract tests
> to cover the API for all file systems.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
