[
https://issues.apache.org/jira/browse/HADOOP-14397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16105395#comment-16105395
]
Manoj Govindassamy commented on HADOOP-14397:
---------------------------------------------
Thanks for working on this [~eddyxu]. v02 patch looks good. +1, pending
following items.
1. New checkstyle issues by v02 patch. Can you please rectify them ?
2. Nit: throw new IOException("Must specify either create or append"); -- does
the error message have to say create, overwrite or append ?
> Pull up the builder pattern to FileSystem and add AbstractContractCreateTest
> for it
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-14397
> URL: https://issues.apache.org/jira/browse/HADOOP-14397
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: common, fs, hdfs-client
> Affects Versions: 2.9.0, 3.0.0-alpha3
> Reporter: Lei (Eddy) Xu
> Assignee: Lei (Eddy) Xu
> Attachments: HADOOP-14397.000.patch, HADOOP-14397.001.patch,
> HADOOP-14397.002.patch
>
>
> After reach the stability of the Builder APIs, we should promote the API from
> {{DistributedFileSystem}} to {{FileSystem}}, and add necessary contract tests
> to cover the API for all file systems.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
