[ https://issues.apache.org/jira/browse/HADOOP-14397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16099625#comment-16099625 ]
Manoj Govindassamy commented on HADOOP-14397: --------------------------------------------- Looks good overall [~eddyxu]. +1, with one question below. bq. {{FileSystem.java}} {noformat} if (getFlags().contains(CreateFlag.CREATE)) { .. } else if (getFlags().contains(CreateFlag.APPEND)) {.. } throw new IOException("Must specify either create or append"); {noformat} Shouldn't the flag CreateFlag.OVERWRITE be treated on the same lines as CREATE ? > Pull up the builder pattern to FileSystem and add AbstractContractCreateTest > for it > ----------------------------------------------------------------------------------- > > Key: HADOOP-14397 > URL: https://issues.apache.org/jira/browse/HADOOP-14397 > Project: Hadoop Common > Issue Type: Sub-task > Components: common, fs, hdfs-client > Affects Versions: 2.9.0, 3.0.0-alpha3 > Reporter: Lei (Eddy) Xu > Assignee: Lei (Eddy) Xu > Attachments: HADOOP-14397.000.patch, HADOOP-14397.001.patch > > > After reach the stability of the Builder APIs, we should promote the API from > {{DistributedFileSystem}} to {{FileSystem}}, and add necessary contract tests > to cover the API for all file systems. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org