[
https://issues.apache.org/jira/browse/HADOOP-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16119955#comment-16119955
]
Aaron Fabbri commented on HADOOP-14749:
---------------------------------------
Thanks for the patch [~ste...@apache.org]. This is good stuff.
{noformat}
/**
- * Should not be called by clients. Only used so {@link org.apache.hadoop
- * .fs.s3a.s3guard.MetadataStore} can maintain this flag when caching
- * FileStatuses on behalf of s3a.
+ * Should not be called by clients. Only used so {@code MetadataStore}
+ * can maintain this flag when caching FileStatuses on behalf of s3a.
* @param value for directories: TRUE / FALSE if known empty/not-empty,
* UNKNOWN otherwise
*/
{noformat}
Actually, can we remove {{setIsEmptyDirectory()}} now? IIRC this is not used
since I reworked the empty directory handling logic.
{noformat}
+ // with a metadata store, the object entries need tup be updated,
+ // including, potentially, the ancestors
{noformat}
/tup/to/
{noformat}
+ /**
+ * Determine the directory status of a path, going via any
+ * MetadataStore before checking S3.
+ * @param path path to check
+ * @return the determined status
+ * @throws IOException IO failure other than FileNotFoundException
+ */
private DirectoryStatus checkPathForDirectory(Path path) throws
IOException {
{noformat}
I thought HADOOP-14505 eliminated checkPathForDirectory()? I had suggested
just using getFileStatus() would be more efficient and less code.
{noformat}
+ // metadata listing is authoritative, so return it directory
{noformat}
/directory/directly/ ?
{noformat}
- // If FileStatus' path is missing host, but should have one, add it.
+ // If FileStatus's path is missing host, but should have one, add it.
{noformat}
Either is correct, BTW.
{noformat}
- assertQualified(srcRoot);
- assertQualified(srcPath);
- assertQualified(dstPath);
+ assertQualified(srcRoot, srcPath, dstPath);
{noformat}
Nice.
{noformat}
+#### Errpr `"DynamoDB table TABLE does not exist in region REGION;
auto-creation is turned off"`
{noformat}
/Errpr/Error/
The docs changes look good, but the diff became a bit hard to follow. Looks
like you moved some stuff to testing doc, which is fine.
> review s3guard docs & code prior to merge
> -----------------------------------------
>
> Key: HADOOP-14749
> URL: https://issues.apache.org/jira/browse/HADOOP-14749
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: documentation, fs/s3
> Affects Versions: HADOOP-13345
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Attachments: HADOOP-14749-HADOOP-13345-001.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Pre-merge cleanup while it's still easy to do
> * Read through all the docs, tune
> * Diff the trunk/branch files to see if we can reduce the delta (and hence
> the changes)
> * Review the new tests
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
