[ 
https://issues.apache.org/jira/browse/HADOOP-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16121069#comment-16121069
 ] 

Mingliang Liu commented on HADOOP-14749:
----------------------------------------

+1. Nice work. Thanks [~ste...@apache.org].

Nits:
# I saw a few TODOs that do not have associated JIRA numbers. Should we file 
and point to them?
# According to my experience at Amazon, {{DynamoDB}} and {{Dynamo}} are two 
different systems though they share lots of core principles and design. Should 
we replace all {{dynamo}} in doc/comment as {{DynamoDB}}?
# In {{S3GuardTool}} L1130, {{code System.exit() on all exeuction paths.}} 
should be {{@code System.exit() on all exeuction paths.}} This has a broader 
question: we currently don't use javadoc to generate HTML doc anymore (don't 
we?), so perhaps we don't need those HTML tags in javadoc which most serves as 
comment. I saw some usage of {{<li>}} for e.g.
# In doc, should we also mention sharing DDB table amortizes the provision 
burden besides cost-effective?
# In doc, there is duplicate "uses" in sentence {{+service uses uses the same 
authentication mechanisms as S3. S3Guard}}
# {{+### Delete a table: `s3guard  destroy`}} has double spaces before destroy
# In the testing doc,
{quote}
... launch the server if it is not yet started; creating the table if it does 
not exist. 
{quote}
{{DynamoDBLocalClientFactory}} is starting a new in-memory local server whose 
instance or data is not shared among tests. So it always starts a new server, 
and create new table. Need to confirm.

> review s3guard docs & code prior to merge
> -----------------------------------------
>
>                 Key: HADOOP-14749
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14749
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: documentation, fs/s3
>    Affects Versions: HADOOP-13345
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>         Attachments: HADOOP-14749-HADOOP-13345-001.patch, 
> HADOOP-14749-HADOOP-13345-002.patch, HADOOP-14749-HADOOP-13345-003.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Pre-merge cleanup while it's still easy to do
> * Read through all the docs, tune
> * Diff the trunk/branch files to see if we can reduce the delta (and hence 
> the changes)
> * Review the new tests



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to