[ https://issues.apache.org/jira/browse/HADOOP-14729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16129499#comment-16129499 ]
Arpit Agarwal commented on HADOOP-14729: ---------------------------------------- Thanks for taking on this monumental task [~ajayydv]. I haven't reviewed the entire patch but here's a few early comments: # There are two deleted test cases in TestConfiguration - testDumpSensitiveProperty and testDumpSensitiveConfiguration # TestDistCh#testDistCh - missing @Test annotation. # TestDU#testDU - missing @Test annotation. # TestFairCallQueue#testDrainTo and #testDrainToWithLimit - missing @Test annotations. > Upgrade JUnit 3 TestCase to JUnit 4 > ----------------------------------- > > Key: HADOOP-14729 > URL: https://issues.apache.org/jira/browse/HADOOP-14729 > Project: Hadoop Common > Issue Type: Test > Reporter: Akira Ajisaka > Assignee: Ajay Kumar > Labels: newbie > Attachments: HADOOP-14729.001.patch, HADOOP-14729.002.patch, > HADOOP-14729.003.patch, HADOOP-14729.004.patch, HADOOP-14729.005.patch, > HADOOP-14729.006.patch > > > There are still test classes that extend from junit.framework.TestCase in > hadoop-common. Upgrade them to JUnit4. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org