[
https://issues.apache.org/jira/browse/HADOOP-14729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16134718#comment-16134718
]
Akira Ajisaka commented on HADOOP-14729:
----------------------------------------
Thanks [~ajayydv] for providing the patches! My comments:
* TestConfiguration#testSetPattern and #testGetClassByNameOrNull - missing
@Test annotations.
* TestDU#testDUGetUsedWillNotReturnNegative - missing @Test annotation.
* TestGetFileBlockLocations#setup and #teardown - javadoc can be removed.
* TestTrash#testPluggableTrash and #performanceTestDeleteSameFile - missing
@Test annotation.
* TestTrash#teardown - javadoc can be removed.
* Would you undo the change in the following class since the classes are
already migrated to JUnit 4 style? :
** ViewFileSystemBaseTest
** TestActiveStandbyElectorRealZK
** TestArrayWritable
** TestWritable
** TestCodec
** TestTFileJClassComparatorByteArrays
** TestTFileLzoCodecsByteArrays
** TestTFileLzoCodecsStreams
** TestTFileNoneCodecsByteArrays
** TestTFileNoneCodecsJClassComparatorByteArrays
** TestTFileNoneCodecsStreams
** TestIPC
** TestDelegationToken
** TestTaskAttempt
** TestMapFileOutputFormat (Nice catch! Missing @After is a bug, should be
addressed in a separate jira.)
** TestJobInfo
** TestInputPath
** TestMiniMRClasspath
** TestAdlFileContextMainOperationsLive
* org.apache.hadoop.mapred.TestFileOutputCommitter#testRecoveryV1 - missing
@Test annotation.
*
org.apache.hadoop.mapreduce.lib.output.TestFileOutputCommitter#testCommitterWithDuplicatedCommitV1
and testMapFileOutputCommitterV2 - missing @Test annotations.
* TestIndexCache#testCreateRace - missing @Test annotation.
* TestJobEndNotifier#testLocalJobRunnerUriSubstitution,
testLocalJobRunnerRetryCount, and testNotificationTimeout - missing @Test
annotations.
* TestMRCJCFileOutputCommitter#testFailAbort - missing @Test annotation.
* Please do not modify the ASF license header in TestLongLong.
> Upgrade JUnit 3 TestCase to JUnit 4
> -----------------------------------
>
> Key: HADOOP-14729
> URL: https://issues.apache.org/jira/browse/HADOOP-14729
> Project: Hadoop Common
> Issue Type: Test
> Reporter: Akira Ajisaka
> Assignee: Ajay Kumar
> Labels: newbie
> Attachments: HADOOP-14729.001.patch, HADOOP-14729.002.patch,
> HADOOP-14729.003.patch, HADOOP-14729.004.patch, HADOOP-14729.005.patch,
> HADOOP-14729.006.patch, HADOOP-14729.007.patch
>
>
> There are still test classes that extend from junit.framework.TestCase in
> hadoop-common. Upgrade them to JUnit4.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
