[
https://issues.apache.org/jira/browse/HADOOP-14729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136509#comment-16136509
]
Akira Ajisaka commented on HADOOP-14729:
----------------------------------------
Thank you for updating the patch, [~ajayydv]! My comments:
* Would you remove @Test from TestTrash#performanceTestDeleteSameFile since
this should not be run as a unit test? Sorry for back and forth.
* Would you undo the change in TestActiveStandbyElectorRealZK and
TestWritableName since the classes are already migrated to JUnit 4 style?
*
org.apache.hadoop.mapreduce.lib.output.TestFileOutputCommitter#testMapFileOutputCommitterV2
- missing @Test annotation.
> Upgrade JUnit 3 TestCase to JUnit 4
> -----------------------------------
>
> Key: HADOOP-14729
> URL: https://issues.apache.org/jira/browse/HADOOP-14729
> Project: Hadoop Common
> Issue Type: Test
> Reporter: Akira Ajisaka
> Assignee: Ajay Kumar
> Labels: newbie
> Attachments: HADOOP-14729.001.patch, HADOOP-14729.002.patch,
> HADOOP-14729.003.patch, HADOOP-14729.004.patch, HADOOP-14729.005.patch,
> HADOOP-14729.006.patch, HADOOP-14729.007.patch, HADOOP-14729.008.patch,
> HADOOP-14729.009.patch
>
>
> There are still test classes that extend from junit.framework.TestCase in
> hadoop-common. Upgrade them to JUnit4.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
