[
https://issues.apache.org/jira/browse/HADOOP-7233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13022569#comment-13022569
]
Aaron T. Myers commented on HADOOP-7233:
----------------------------------------
+1, The code looks good to me.
One high-level comment: this refactor of FsShell is making a lot of changes and
leaving a lot of TODOs in the code, all of which will be removed once the total
refactor is completed. Since you're proceeding by piecemeal switching the
commands over to the new system, might it make sense to do all this work in a
branch, and then let us review the final product? It seems unfortunate to have
transitional code in trunk over the course of this whole project, and there's
the obvious question of what happens to the TODOs if the total refactor is
never completed.
> Refactor FsShell's ls
> ---------------------
>
> Key: HADOOP-7233
> URL: https://issues.apache.org/jira/browse/HADOOP-7233
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 0.23.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-7233.patch
>
>
> Need to refactor ls to conform to new FsCommand class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
