[
https://issues.apache.org/jira/browse/HADOOP-7233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13022759#comment-13022759
]
Daryn Sharp commented on HADOOP-7233:
-------------------------------------
Thanks for the quick review!
My concern with making the changes on a separate branch is the time it will
take to review and commit the changes. I'm trying to avoid a "big bang"
integration that will be harder for a committer, and require me to perform
manual merges of any changes that occur in common and/or hdfs until it's
committed. If others feel strongly, I can pursue a branch.
Regarding the TODOs, I have added 9 in the code I have touched. They are more
of a wish list than truly transitional detritus. I do intend to address most
of them, but the overall task is neither at risk, nor left in a bad shape if
not completed (which I am committed to completing). The breakdown is:
* 1 is that ls should be iterative (technically out of scope for my work)
* 1 is about how the descriptive text should be auto-wrapped (nice to have)
* 5 are about standardizing the existing text of exceptions (nice to have)
* 1 is about better exit codes which already has another jira (nice to have)
* 1 is about less than ideal instantiation of the command factory, which is
only an issue if dfsadmin and fsshell share a common base class instead of
dfsadmin deriving from fsshell (nice to have)
> Refactor FsShell's ls
> ---------------------
>
> Key: HADOOP-7233
> URL: https://issues.apache.org/jira/browse/HADOOP-7233
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 0.23.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-7233.patch
>
>
> Need to refactor ls to conform to new FsCommand class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
