[
https://issues.apache.org/jira/browse/HADOOP-7233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13022859#comment-13022859
]
Daryn Sharp commented on HADOOP-7233:
-------------------------------------
Oops. I botched that, but it's never actually called (currently). The method
is intended to return a string of the text for a FileNotFoundException since
every command's text seems slightly different. The above base class was
supposed to throw "not implemented", or return the string that got thrown. I
munged it, but it's not called, so I'll fix it in the next refactored command
review.
The end goal is "throw PathNotFoundException(path)" which will enforce a
standard text message, and have a getter for the path. I intend to first
refactor all FsShell commands. I can then universally change them all to use
the new exception with just 2 LOC, and another jira to update all the hdfs
tests.
I can see the wisdom of using a branch for larger features. Unfortunately in
this case, code is being moved from a file into new files, which would make
merges completely manual and error-prone. I also have someone waiting on my
changes so they can add symlink support. Hence my hesitancy to use a branch...
> Refactor FsShell's ls
> ---------------------
>
> Key: HADOOP-7233
> URL: https://issues.apache.org/jira/browse/HADOOP-7233
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Affects Versions: 0.23.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Fix For: 0.23.0
>
> Attachments: HADOOP-7233.patch
>
>
> Need to refactor ls to conform to new FsCommand class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
