[ 
https://issues.apache.org/jira/browse/HADOOP-15523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16505686#comment-16505686
 ] 

Bibin A Chundatt commented on HADOOP-15523:
-------------------------------------------

[~BilwaST]

Please do handle the following as part for the patch 

# javadoc update for Shell#getTimeoutInterval
{code}
    /**
     * Returns the timeout value set for the executor's sub-commands.
     *
     * @return The timeout value in seconds
     */
    @VisibleForTesting
    public long getTimeoutInterval() {
      return timeOutInterval;
    }
{code}
# Add/Update the testcase added as part of HADOOP-13817 too.

> Shell command timeout given is in seconds whereas it is taken as millisec 
> while scheduling
> ------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-15523
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15523
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Bilwa S T
>            Assignee: Bilwa S T
>            Priority: Major
>
> ShellBasedUnixGroupsMapping has a property 
> {{hadoop.security.groups.shell.command.timeout}} to control how long to wait 
> for the fetch groups command which can be configured in seconds. but while 
> scheduling the time taken is millisecs. so currently if u give value as 60s, 
> it is taken as 60ms.
> {code:java}
> timeout = conf.getTimeDuration(
> CommonConfigurationKeys.
> HADOOP_SECURITY_GROUP_SHELL_COMMAND_TIMEOUT_SECS,
> CommonConfigurationKeys.
> HADOOP_SECURITY_GROUP_SHELL_COMMAND_TIMEOUT_SECS_DEFAULT,
> TimeUnit.SECONDS);{code}
> Time unit given is in seconds but it should be millisecs



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to