[
https://issues.apache.org/jira/browse/HADOOP-15523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16507284#comment-16507284
]
Nanda kumar commented on HADOOP-15523:
--------------------------------------
Thanks [~BilwaST] for reporting and working on this.
Overall the patch looks good to me, some minor comments.
We can rename the property key name in {{CommonConfigurationKeysPublic}}:
* from {{HADOOP_SECURITY_GROUP_SHELL_COMMAND_TIMEOUT_SECS}} to
{{HADOOP_SECURITY_GROUP_SHELL_COMMAND_TIMEOUT_KEY}}
* from {{HADOOP_SECURITY_GROUP_SHELL_COMMAND_TIMEOUT_SECS_DEFAULT}} to
{{HADOOP_SECURITY_GROUP_SHELL_COMMAND_TIMEOUT_DEFAULT}}
Not related to this patch:
*ShellBasedUnixGroupsMapping.java*
Line:21 unused import
Line:55 {{"timeout = 0L"}} can be re-factored to
{{"timeout =
CommonConfigurationKeys.HADOOP_SECURITY_GROUP_SHELL_COMMAND_TIMEOUT_DEFAULT"}}
> Shell command timeout given is in seconds whereas it is taken as millisec
> while scheduling
> ------------------------------------------------------------------------------------------
>
> Key: HADOOP-15523
> URL: https://issues.apache.org/jira/browse/HADOOP-15523
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Bilwa S T
> Assignee: Bilwa S T
> Priority: Major
> Attachments: HADOOP-15523-001.patch
>
>
> ShellBasedUnixGroupsMapping has a property
> {{hadoop.security.groups.shell.command.timeout}} to control how long to wait
> for the fetch groups command which can be configured in seconds. but while
> scheduling the time taken is millisecs. so currently if u give value as 60s,
> it is taken as 60ms.
> {code:java}
> timeout = conf.getTimeDuration(
> CommonConfigurationKeys.
> HADOOP_SECURITY_GROUP_SHELL_COMMAND_TIMEOUT_SECS,
> CommonConfigurationKeys.
> HADOOP_SECURITY_GROUP_SHELL_COMMAND_TIMEOUT_SECS_DEFAULT,
> TimeUnit.SECONDS);{code}
> Time unit given is in seconds but it should be millisecs
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
