[
https://issues.apache.org/jira/browse/HADOOP-15523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16511898#comment-16511898
]
Surendra Singh Lilhore commented on HADOOP-15523:
-------------------------------------------------
Thanks [~BilwaST] for reporting this issue.
some minor comment from my side for test case.
# In {{TestShellBasedUnixGroupsMapping#testShellTimeOutConf()}} move common
code in one method.
# In {{TestShellBasedUnixGroupsMapping#testFiniteGroupResolutionTime()}} at
line 150 use setLog(), no need to hard code timeout.
once above comments are addressed +1 from my side.
> Shell command timeout given is in seconds whereas it is taken as millisec
> while scheduling
> ------------------------------------------------------------------------------------------
>
> Key: HADOOP-15523
> URL: https://issues.apache.org/jira/browse/HADOOP-15523
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Bilwa S T
> Assignee: Bilwa S T
> Priority: Major
> Attachments: HADOOP-15523-001.patch, HADOOP-15523-002.patch,
> HADOOP-15523-003.patch
>
>
> ShellBasedUnixGroupsMapping has a property
> {{hadoop.security.groups.shell.command.timeout}} to control how long to wait
> for the fetch groups command which can be configured in seconds. but while
> scheduling the time taken is millisecs. so currently if u give value as 60s,
> it is taken as 60ms.
> {code:java}
> timeout = conf.getTimeDuration(
> CommonConfigurationKeys.
> HADOOP_SECURITY_GROUP_SHELL_COMMAND_TIMEOUT_SECS,
> CommonConfigurationKeys.
> HADOOP_SECURITY_GROUP_SHELL_COMMAND_TIMEOUT_SECS_DEFAULT,
> TimeUnit.SECONDS);{code}
> Time unit given is in seconds but it should be millisecs
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
