[
https://issues.apache.org/jira/browse/HADOOP-15586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550025#comment-16550025
]
Haibo Chen commented on HADOOP-15586:
-------------------------------------
Hi [~snemeth]. I'd echo [~ste...@apache.org]'s previous comment, we just need
to change "LOG.debug("noteFailure {}" + exception);" to "LOG.debug("noteFailure
{}", exception);"
The other change is unnecessary, and "Exception in noteFailure" is a bit
misleading because it is not an exception thrown/caught in noteFailure().
noteFailure() is a just helper method.
> Fix wrong log statements in AbstractService
> -------------------------------------------
>
> Key: HADOOP-15586
> URL: https://issues.apache.org/jira/browse/HADOOP-15586
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 2.9.0, 3.1.0
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Minor
> Attachments: HADOOP-15586-001.patch, HADOOP-15586-002.patch
>
>
> There are some wrong logging statements in AbstractService, here is one
> example:
> {code:java}
> LOG.debug("noteFailure {}" + exception);
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
