[ 
https://issues.apache.org/jira/browse/HADOOP-15586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16551065#comment-16551065
 ] 

Haibo Chen commented on HADOOP-15586:
-------------------------------------

{quote}LOG.debug has one signature to use a format string plus the objects as 
arguments to format, and the other one is String plus a Throwable instance
{quote}
I see. 

I will check it in later today if no objections.

I would revert the change to the indention when I commit to be consistent with 
the rest of the code base which uses 4 spaces.

> Fix wrong log statements in AbstractService
> -------------------------------------------
>
>                 Key: HADOOP-15586
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15586
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: util
>    Affects Versions: 2.9.0, 3.1.0
>            Reporter: Szilard Nemeth
>            Assignee: Szilard Nemeth
>            Priority: Minor
>         Attachments: HADOOP-15586-001.patch, HADOOP-15586-002.patch, 
> HADOOP-15586-003.patch
>
>
> There are some wrong logging statements in AbstractService, here is one 
> example: 
> {code:java}
> LOG.debug("noteFailure {}" + exception);
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to