[
https://issues.apache.org/jira/browse/HADOOP-15586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550333#comment-16550333
]
Szilard Nemeth commented on HADOOP-15586:
-----------------------------------------
Hi [~haibochen]! I would say LOG.debug("noteFailure {}", exception) is not that
great, as LOG.debug has one signature to use a format string plus the objects
as arguments to format, and the other one is String plus a Throwable instance.
So I would use "LOG.debug("noteFailure", exception);" instead.
Uploaded a new patch according to this.
> Fix wrong log statements in AbstractService
> -------------------------------------------
>
> Key: HADOOP-15586
> URL: https://issues.apache.org/jira/browse/HADOOP-15586
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 2.9.0, 3.1.0
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Minor
> Attachments: HADOOP-15586-001.patch, HADOOP-15586-002.patch
>
>
> There are some wrong logging statements in AbstractService, here is one
> example:
> {code:java}
> LOG.debug("noteFailure {}" + exception);
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
