[
https://issues.apache.org/jira/browse/HADOOP-15660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578961#comment-16578961
]
genericqa commented on HADOOP-15660:
------------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
21s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} HADOOP-15407 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 35m
1s{color} | {color:green} HADOOP-15407 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
30s{color} | {color:green} HADOOP-15407 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
23s{color} | {color:green} HADOOP-15407 passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
31s{color} | {color:green} HADOOP-15407 passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
12m 33s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
46s{color} | {color:green} HADOOP-15407 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
27s{color} | {color:green} HADOOP-15407 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
28s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 18s{color} | {color:orange} hadoop-tools/hadoop-azure: The patch generated 1
new + 3 unchanged - 1 fixed = 4 total (was 4) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
13m 26s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
57s{color} | {color:red} hadoop-tools/hadoop-azure generated 6 new + 0
unchanged - 0 fixed = 6 total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
24s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
12s{color} | {color:green} hadoop-azure in the patch passed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
26s{color} | {color:red} The patch generated 1 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 69m 14s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-tools/hadoop-azure |
| | Exception is caught when Exception is not thrown in
org.apache.hadoop.fs.azurebfs.AbfsConfiguration.getTokenProvider(String) At
AbfsConfiguration.java:is not thrown in
org.apache.hadoop.fs.azurebfs.AbfsConfiguration.getTokenProvider(String) At
AbfsConfiguration.java:[line 313] |
| | Found reliance on default encoding in
org.apache.hadoop.fs.azurebfs.oauth2.AzureADAuthenticator.consumeInputStream(InputStream,
int):in
org.apache.hadoop.fs.azurebfs.oauth2.AzureADAuthenticator.consumeInputStream(InputStream,
int): new String(byte[], int, int) At AzureADAuthenticator.java:[line 300] |
| |
org.apache.hadoop.fs.azurebfs.oauth2.AzureADAuthenticator.getTokenSingleCall(String,
String, Hashtable, String) makes inefficient use of keySet iterator instead of
entrySet iterator At AzureADAuthenticator.java:inefficient use of keySet
iterator instead of entrySet iterator At AzureADAuthenticator.java:[line 204] |
| | org.apache.hadoop.fs.azurebfs.oauth2.AzureADToken.getExpiry() may expose
internal representation by returning AzureADToken.expiry At
AzureADToken.java:by returning AzureADToken.expiry At AzureADToken.java:[line
40] |
| | org.apache.hadoop.fs.azurebfs.oauth2.AzureADToken.setExpiry(Date) may
expose internal representation by storing an externally mutable object into
AzureADToken.expiry At AzureADToken.java:by storing an externally mutable
object into AzureADToken.expiry At AzureADToken.java:[line 44] |
| | org.apache.hadoop.fs.azurebfs.oauth2.QueryParams.serialize() makes
inefficient use of keySet iterator instead of entrySet iterator At
QueryParams.java:keySet iterator instead of entrySet iterator At
QueryParams.java:[line 52] |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:ba1ab08 |
| JIRA Issue | HADOOP-15660 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12935429/HADOOP-15660-HADOOP-15407-001.patch
|
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit shadedclient findbugs checkstyle |
| uname | Linux de9cd1d2ab61 3.13.0-144-generic #193-Ubuntu SMP Thu Mar 15
17:03:53 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | HADOOP-15407 / 7262485 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_171 |
| findbugs | v3.1.0-RC1 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HADOOP-Build/15023/artifact/out/diff-checkstyle-hadoop-tools_hadoop-azure.txt
|
| findbugs |
https://builds.apache.org/job/PreCommit-HADOOP-Build/15023/artifact/out/new-findbugs-hadoop-tools_hadoop-azure.html
|
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/15023/testReport/ |
| asflicense |
https://builds.apache.org/job/PreCommit-HADOOP-Build/15023/artifact/out/patch-asflicense-problems.txt
|
| Max. process+thread count | 302 (vs. ulimit of 10000) |
| modules | C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/15023/console |
| Powered by | Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> ABFS: Add support for OAuth
> ---------------------------
>
> Key: HADOOP-15660
> URL: https://issues.apache.org/jira/browse/HADOOP-15660
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Da Zhou
> Assignee: Da Zhou
> Priority: Major
> Attachments: HADOOP-15660-HADOOP-15407-001.patch
>
>
> - Add support for OAuth
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
