[
https://issues.apache.org/jira/browse/HADOOP-15660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16579031#comment-16579031
]
Thomas Marquardt commented on HADOOP-15660:
-------------------------------------------
Looks good overall. We will need to add test coverage for this before
committing this patch. I know it is not easy, but we should be able to do it.
*General Comments*:
For the newly added files, can you edit them to stay
below the 80 character per line limit?
*AzureADAuthenticator.java*:
L28-30 - Can we use codehaus instead of fasterxml? We currently depend on
codehaus.
L50, L99, L102, L107,
*UserPasswordTokenProvider.java*:
L39 - getLogger(AccessTokenProvider.class);
The other subclasses use the AccessTokenProvider logger, which makes sense as
it
is easier to use when you need to edit the log4j.properties file.
*AbfsRestOperation.java*:
L52 - Can we revert this back to "LOG", instead of changing it to "logger"?
*AzureBlobFileSystemStore.java*:
L501 - Looks like L492-496 needs to be moved inside this "if" statement, and
then pass dotIndex to
the constructor. Otherwise we no longer do the validation on L494.
> ABFS: Add support for OAuth
> ---------------------------
>
> Key: HADOOP-15660
> URL: https://issues.apache.org/jira/browse/HADOOP-15660
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Da Zhou
> Assignee: Da Zhou
> Priority: Major
> Attachments: HADOOP-15660-HADOOP-15407-001.patch
>
>
> - Add support for OAuth
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
