[
https://issues.apache.org/jira/browse/HADOOP-15739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611306#comment-16611306
]
Da Zhou commented on HADOOP-15739:
----------------------------------
Thanks [[email protected]] for the review.
The changes I made is based on results of
{code:java}
mvn dependency:analyze{code}
, which gives me:
{noformat}
[WARNING] Used undeclared dependencies found:
[WARNING] log4j:log4j:jar:1.2.17:provided
[WARNING] org.apache.commons:commons-lang3:jar:3.7:provided
[WARNING] org.apache.hadoop:hadoop-annotations:jar:3.2.0-SNAPSHOT:provided
[WARNING] javax.ws.rs:jsr311-api:jar:1.1.1:provided
[WARNING] javax.xml.bind:jaxb-api:jar:2.2.11:provided
[WARNING] org.slf4j:slf4j-api:jar:1.7.25:compile
[WARNING] commons-logging:commons-logging:jar:1.1.3:compile
[WARNING] commons-codec:commons-codec:jar:1.11:compile
[WARNING] com.fasterxml.jackson.core:jackson-databind:jar:2.9.5:provided
[WARNING] org.apache.httpcomponents:httpcore:jar:4.4.4:compile
[WARNING] Unused declared dependencies found:
[WARNING] com.google.inject:guice:jar:4.0:compile
[WARNING]
org.apache.hadoop:hadoop-mapreduce-client-jobclient:jar:3.2.0-SNAPSHOT:test
[WARNING] org.apache.hadoop:hadoop-distcp:jar:3.2.0-SNAPSHOT:test
{noformat}
Regarding to your comments:
{quote}hamcrest-library already pulls in hamcrest core.
{quote}
Are you suggesting changing the dependency declaration from hamcrest-core to
hamcrest-library? I tried that and mvn depdency:tree gives me:
{noformat}
[INFO] +- junit:junit:jar:4.11:test
[INFO] | \- org.hamcrest:hamcrest-core:jar:1.3:test
[INFO] +- org.hamcrest:hamcrest-library:jar:1.3:test
{noformat}
Looks like the we don't need to declare hamcrest-library or hamcrest-core?
{quote}is log4j really needed in production?
{quote}
No, only WASB's tests need it. I will change its scope to test.
{quote}Why are jaxb-api & jsr311-api being removed as explicit dependencies?
{quote}
Both of them are complained by mvn dependency:analyze (see below analyze
result), so I added them to Azure pom as explicit dependencies.
{quote}I'd be happiest if the dependencies in hadoop-azure declared everything,
but the pom hadoop-cloud-storage-project/hadoop-cloud-storage/pom.xml stripped
things down, as that's the one that downstream projects have been picking up.
{quote}
I might miss some context so that I didn't get your point. I see
hadoop-cloud-storage/pom.xml has a dependency on hadoop azure, so what should I
do with it?
> ABFS: remove unused maven dependencies and add used undeclared dependencies
> ---------------------------------------------------------------------------
>
> Key: HADOOP-15739
> URL: https://issues.apache.org/jira/browse/HADOOP-15739
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: build, fs/azure
> Affects Versions: HADOOP-15407
> Reporter: Da Zhou
> Assignee: Da Zhou
> Priority: Major
> Attachments: HADOOP-15739-HADOOP-15407-001.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
