[
https://issues.apache.org/jira/browse/HADOOP-15836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660697#comment-16660697
]
BELUGA BEHR commented on HADOOP-15836:
--------------------------------------
As we've seen in the unit tests, this class is used to generate ACL strings:
bq. I think it might be more pleasant to a human operator if the list is
ordered alphabetically.
I proposed this change for that reason. Using a {{HashSet}}, the users and
groups are seemingly randomly ordered, which is mildly confusing since this
information is supplied trough a configuration. The output string will likely
not match the input string, so we can at least alphabetize it. People will
understand that ordering and it may be a little easier to troubleshoot. Thanks.
> Review of AccessControlList
> ---------------------------
>
> Key: HADOOP-15836
> URL: https://issues.apache.org/jira/browse/HADOOP-15836
> Project: Hadoop Common
> Issue Type: Improvement
> Components: common, security
> Affects Versions: 3.2.0
> Reporter: BELUGA BEHR
> Assignee: BELUGA BEHR
> Priority: Minor
> Fix For: 3.3.0
>
> Attachments: HADOOP-15836.1.patch
>
>
> * Improve unit tests (expected / actual were backwards)
> * Unit test expected elements to be in order but the class's return
> Collections were unordered
> * Formatting cleanup
> * Removed superfluous white space
> * Remove use of LinkedList
> * Removed superfluous code
> * Use {{unmodifiable}} Collections where JavaDoc states that caller must not
> manipulate the data structure
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
