[
https://issues.apache.org/jira/browse/HADOOP-15836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661488#comment-16661488
]
Wilfred Spiegelenburg commented on HADOOP-15836:
------------------------------------------------
I still think we need to make sure that the tests are not sensitive to ordering
also. In the YARN case the user that runs the service is added to the admin ACL
by the code (YARN-3804). If we maintain order on insert a code change could
then break tests again. Checking the returned ACL string independent of the
order is not that difficult (see attached proposal
[^assertEqualACLStrings.patch] ).
Replacing all the direct string compares of ACLs in tests should be a small
effort with that.
> Review of AccessControlList
> ---------------------------
>
> Key: HADOOP-15836
> URL: https://issues.apache.org/jira/browse/HADOOP-15836
> Project: Hadoop Common
> Issue Type: Improvement
> Components: common, security
> Affects Versions: 3.2.0
> Reporter: BELUGA BEHR
> Assignee: BELUGA BEHR
> Priority: Minor
> Fix For: 3.3.0
>
> Attachments: HADOOP-15836.1.patch, assertEqualACLStrings.patch
>
>
> * Improve unit tests (expected / actual were backwards)
> * Unit test expected elements to be in order but the class's return
> Collections were unordered
> * Formatting cleanup
> * Removed superfluous white space
> * Remove use of LinkedList
> * Removed superfluous code
> * Use {{unmodifiable}} Collections where JavaDoc states that caller must not
> manipulate the data structure
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
