[
https://issues.apache.org/jira/browse/HADOOP-15836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660730#comment-16660730
]
Jason Lowe commented on HADOOP-15836:
-------------------------------------
bq. this information is supplied trough a configuration
If we want to get pedantic about ordering then shouldn't the order specified in
the configuration be the order that is preserved? That order isn't necessarily
lexicographical.
If there's a pressing need to order the results of getAclString then fine, we
can do that. But that does not require the AccessControlList implementation to
preserve that order at all times. As I understand it, isUserAllowed is the
critical path on this class and getAclString is relatively rare. That makes me
think this patch is optimizing for the rare case at the expense of the common
case.
> Review of AccessControlList
> ---------------------------
>
> Key: HADOOP-15836
> URL: https://issues.apache.org/jira/browse/HADOOP-15836
> Project: Hadoop Common
> Issue Type: Improvement
> Components: common, security
> Affects Versions: 3.2.0
> Reporter: BELUGA BEHR
> Assignee: BELUGA BEHR
> Priority: Minor
> Fix For: 3.3.0
>
> Attachments: HADOOP-15836.1.patch
>
>
> * Improve unit tests (expected / actual were backwards)
> * Unit test expected elements to be in order but the class's return
> Collections were unordered
> * Formatting cleanup
> * Removed superfluous white space
> * Remove use of LinkedList
> * Removed superfluous code
> * Use {{unmodifiable}} Collections where JavaDoc states that caller must not
> manipulate the data structure
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
